Review fixes.

review/src/ReviewConfig.elm

@@ -131,6 +131,7 @@ config =
                         , "src/TestResult.elm"
                         , "src/Parser/Extra/String.elm"
                         ]
+                    |> Rule.ignoreErrorsForFiles [ "src/Stub.elm" ]
             )
 
 

src/BackendTask/Internal/Request.elm

@@ -1,7 +1,7 @@
 module BackendTask.Internal.Request exposing (request, request2)
 
 import BackendTask exposing (BackendTask)
-import BackendTask.Http exposing (Body, Error(..), Expect)
+import BackendTask.Http exposing (Body, Expect)
 import Json.Decode exposing (Decoder)
 import Json.Encode as Encode
 
@@ -24,7 +24,7 @@ request ({ name, body, expect } as params) =
         }
         expect
         |> BackendTask.onError
-            (\error ->
+            (\_ ->
                 -- TODO avoid crash here, this should be handled as an internal error
                 request params
             )
@@ -38,7 +38,7 @@ request2 :
     , onError : Json.Decode.Error -> error
     }
     -> BackendTask error a
-request2 ({ name, body, expect, onError, errorDecoder } as params) =
+request2 { name, body, expect, onError, errorDecoder } =
     -- elm-review: known-unoptimized-recursion
     BackendTask.Http.request
         { url = "elm-pages-internal://" ++ name
@@ -50,7 +50,7 @@ request2 ({ name, body, expect, onError, errorDecoder } as params) =
         }
         (BackendTask.Http.expectJson Json.Decode.value)
         |> BackendTask.onError
-            (\error ->
+            (\_ ->
                 BackendTask.succeed Encode.null
             )
         |> BackendTask.andThen

src/Pages/Form.elm

@@ -16,7 +16,7 @@ import Dict exposing (Dict)
 import FatalError exposing (FatalError)
 import Form
 import Form.Handler
-import Form.Validation as Validation exposing (Validation)
+import Form.Validation exposing (Validation)
 import Html
 import Html.Styled
 import Pages.Internal.Msg
@@ -42,7 +42,7 @@ type alias FormWithServerValidations error combined input view =
 
 {-| -}
 type alias Handler error combined =
-    Form.Handler.Handler error (BackendTask FatalError (Validation.Validation error combined Never Never))
+    Form.Handler.Handler error (BackendTask FatalError (Validation error combined Never Never))
 
 
 {-| -}

src/Pages/Internal/Msg.elm

@@ -1,20 +1,15 @@
 module Pages.Internal.Msg exposing
-    (  Msg(..)
-       --, fetcherOnSubmit
-
-    ,  map
-       --, onSubmit
-       --, submitIfValid
-
+    ( Msg(..)
+      --, fetcherOnSubmit
+    , map
+      --, onSubmit
+      --, submitIfValid
     )
 
 --import Form.FormData exposing (FormData)
 --import FormDecoder
 
 import Form exposing (Method)
-import Html exposing (Attribute)
-import Html.Attributes as Attr
-import Json.Decode
 
 
 {-| -}
@@ -75,6 +70,7 @@ type Msg userMsg
 {-| -}
 map : (a -> b) -> Msg a -> Msg b
 map mapFn msg =
+    -- elm-review: known-unoptimized-recursion
     case msg of
         UserMsg userMsg ->
             UserMsg (mapFn userMsg)
@@ -91,8 +87,7 @@ map mapFn msg =
                 }
 
         FormMsg value ->
-            FormMsg
-                (Form.mapMsg (map mapFn) value)
+            FormMsg (Form.mapMsg (map mapFn) value)
 
         NoOp ->
             NoOp

src/Pages/Internal/Platform.elm

@@ -505,16 +505,16 @@ update config appMsg model =
                         |> performUserMsg userMsg config
 
                 Pages.Internal.Msg.Submit fields ->
-                    let
-                        payload : { fields : List ( String, String ), method : Form.Method, action : String, id : Maybe String }
-                        payload =
-                            { fields = fields.fields
-                            , method = fields.method
-                            , action = fields.action
-                            , id = Just fields.id
-                            }
-                    in
                     if fields.valid then
+                        let
+                            payload : { fields : List ( String, String ), method : Form.Method, action : String, id : Maybe String }
+                            payload =
+                                { fields = fields.fields
+                                , method = fields.method
+                                , action = fields.action
+                                , id = Just fields.id
+                                }
+                        in
                         if fields.useFetcher then
                             ( { model | nextTransitionKey = model.nextTransitionKey + 1 }
                             , SubmitFetcher fields.id model.nextTransitionKey payload
@@ -988,7 +988,7 @@ perform config model effect =
                             , fromPageMsg = Pages.Internal.Msg.UserMsg >> UserMsg
                             , key = key
                             , setField =
-                                \info ->
+                                \_ ->
                                     --Task.succeed (SetField info) |> Task.perform identity
                                     -- TODO
                                     Cmd.none

src/Pages/Internal/Platform/GeneratorApplication.elm

@@ -32,7 +32,7 @@ type alias JsonValue =
 
 {-| -}
 type alias Program =
-    Program.StatefulProgram Model Msg (BackendTask FatalError.FatalError ()) Flags
+    Program.StatefulProgram Model Msg (BackendTask FatalError ()) Flags
 
 
 {-| -}

src/Pages/Internal/Platform/StaticResponses.elm

@@ -1,9 +1,8 @@
-module Pages.Internal.Platform.StaticResponses exposing (NextStep(..), empty, nextStep, renderApiRequest)
+module Pages.Internal.Platform.StaticResponses exposing (NextStep(..), empty, nextStep)
 
 import BackendTask exposing (BackendTask)
 import BuildError exposing (BuildError)
 import FatalError exposing (FatalError)
-import List.Extra
 import Pages.Internal.FatalError
 import Pages.StaticHttp.Request as HashRequest
 import Pages.StaticHttpRequest as StaticHttpRequest
@@ -16,13 +15,6 @@ empty a =
     BackendTask.succeed a
 
 
-renderApiRequest :
-    BackendTask FatalError response
-    -> BackendTask FatalError response
-renderApiRequest request =
-    request
-
-
 type NextStep route value
     = Continue (List HashRequest.Request) (StaticHttpRequest.RawRequest FatalError value)
     | Finish value

src/Pages/Transition.elm

@@ -1,11 +1,11 @@
 module Pages.Transition exposing
-    ( Transition(..), LoadingState(..), map
+    ( Transition(..), LoadingState(..), map, FormData
     , FetcherState, FetcherSubmitStatus(..)
     )
 
 {-|
 
-@docs Transition, LoadingState, map
+@docs Transition, LoadingState, map, FormData
 
 
 ## Fetchers

src/Server/Request.elm

@@ -98,7 +98,6 @@ import Internal.Request
 import Json.Decode
 import Json.Encode
 import List.NonEmpty
-import Pages.Form
 import QueryParams
 import Time
 import Url
@@ -949,7 +948,7 @@ formData formParsers =
         |> andThen
             (\rawFormData_ ->
                 case Form.Handler.run rawFormData_ formParsers of
-                    (Form.Valid decoded) as validated ->
+                    (Form.Valid _) as validated ->
                         ( { persisted =
                                 { fields = Just rawFormData_
                                 , clientSideErrors = Just Dict.empty
@@ -960,7 +959,7 @@ formData formParsers =
                         )
                             |> succeed
 
-                    (Form.Invalid maybeDecoded maybeErrors) as validated ->
+                    (Form.Invalid _ maybeErrors) as validated ->
                         ( { persisted =
                                 { fields = Just rawFormData_
                                 , clientSideErrors = Just maybeErrors

src/Stub.elm

@@ -1,4 +1,4 @@
-module Stub exposing (..)
+module Stub exposing (Id, Model, Task(..), map2, nextId)
 
 import Json.Decode as Decode
 import Set exposing (Set)
@@ -24,29 +24,26 @@ type alias Model =
 
 type Task error value
     = Pending (Id -> Id) (Decode.Value -> Model -> ( Model, Task error value ))
-    | Done (Result error value)
 
 
 map2 : (value1 -> value2 -> combined) -> Task error value1 -> Task error value2 -> Task error combined
 map2 mapFn task1 task2 =
     case ( task1, task2 ) of
-        ( Done resolved1, Done resolved2 ) ->
-            Debug.todo ""
-
-        ( Pending toId1 resolved1, Pending toId2 resolved2 ) ->
+        ( Pending toId1 _, Pending toId2 _ ) ->
             Pending
                 (\id ->
                     max (toId1 id) (toId2 id)
                         |> nextId
                 )
-                (\value id ->
+                (\_ _ ->
                     Debug.todo ""
                 )
 
         _ ->
             Debug.todo ""
 
 
+nextId : Int -> Int
 nextId id =
     id + 1
 

tests/ApiRouteTests.elm

@@ -3,7 +3,6 @@ module ApiRouteTests exposing (all)
 import ApiRoute exposing (..)
 import BackendTask
 import Expect
-import FatalError
 import Internal.ApiRoute exposing (tryMatch, withRoutes)
 import Pattern exposing (Pattern(..))
 import Server.Request

tests/CookieTest.elm

@@ -3,7 +3,6 @@ module CookieTest exposing (all)
 import CookieParser
 import Dict
 import Expect
-import FatalError
 import Test exposing (Test, describe, test)
 
 

tests/FormDataTest.elm

@@ -2,7 +2,6 @@ module FormDataTest exposing (all)
 
 import Dict
 import Expect
-import FatalError
 import FormData
 import Test exposing (Test, describe, test)
 

tests/HeadTests.elm

@@ -1,7 +1,6 @@
 module HeadTests exposing (suite)
 
 import Expect
-import FatalError
 import Head
 import Json.Decode
 import Test exposing (Test, describe, test)

tests/Pages/RouteParamsTest.elm

@@ -6,7 +6,6 @@ import Elm.CodeGen
 import Elm.Pretty
 import Elm.ToString
 import Expect exposing (Expectation)
-import FatalError
 import Fuzz exposing (Fuzzer)
 import Pages.Internal.RoutePattern as RoutePattern
 import Pretty