Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added framework project for Carthage support #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eliburke
Copy link

@iscriptology here's a preliminary PR for Carthage support.

I think that it is possible to create a project that supports both CocoaPods and Carthage, but I don't know how, so for now I've done it as a separate xcodeproj

You will need to tag a new release for it to actually become available to Carthage (0.2.1 or 0.3.0)

@yosef-abraham
Copy link
Owner

yosef-abraham commented Oct 23, 2016

I need to find time to investigate Carthage before I merge this. (as I never used it)
Hopefully I'll do it soon.
Thank you for the PR, waiting for your MP one :)

@eliburke
Copy link
Author

So... two things about the MsgPack merge...

  1. it's dependent on the carthage PR. If you want me to PR just the source file I can, and you can figure out the cocoa pods update
  2. it's dependent on my fork of a2/messagepack.swift-- I'm waiting for him to integrate a carthage patch.

FYI, carthage is pretty simple. It just needs a xcodeproj that builds a framework and has a build scheme that is marked as shared. Swamp is just a little more complex than many because of the nested frameworks.

@sberryman
Copy link

Is there any reason carthage support hasn't been merged in yet?

@tomtom5152
Copy link

Would also like to see this merged as I'd rather not have two dependancy managers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants