Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for adding files that are not associated with a target #1268

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

skofgar
Copy link
Contributor

@skofgar skofgar commented Sep 29, 2022

For some projects it might be helpful to add files to a project that don't belong to a specific target.

For example, README.md files or the project.yml.

files:
  - path: README.md
  - path: project.yml
  - path: Resources/Config
    name: Config
    includes:
      - "*.json"

Known Issues

  • Currently I just use TargetSources to achieve this capability. If the general direction of this PR is acceptable, then I would - in a separate PR - rename TargetSources to SourcesReference (or something similar)

@skofgar skofgar changed the title adding support for adding files that don't belong to a target adding support for adding files that are not associated with a target Sep 29, 2022
@skofgar
Copy link
Contributor Author

skofgar commented Oct 7, 2022

Hi @yonaskolb may I request a review for this PR?

@yonaskolb
Copy link
Owner

Interestingly this is what fileGroups is for. The name doesn't suggest it can be used for single files though. Are the options exposed by TargetSource required for your use case? If not, perhaps we just deprecate and rename fileGroups to files, while still supporting fileGroups for backwards compatibility.

@skofgar
Copy link
Contributor Author

skofgar commented Nov 2, 2022

Oh really 🤦‍♂️, sorry I didn’t realize it.

I do have a use case where the include filter options would be really helpful.

I’ll look into fileGroups more and update this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants