Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use logging instead of print #86

Merged
merged 10 commits into from
Dec 21, 2023
Merged

use logging instead of print #86

merged 10 commits into from
Dec 21, 2023

Conversation

gkorland
Copy link
Contributor

@gkorland gkorland commented Dec 21, 2023

Summary by CodeRabbit

  • Refactor
    • Improved application logging by integrating the logging module for enhanced message management.
    • Refactored method for retrieving graph data in the Neo4j class.
    • Adjusted method for retrieving graph history in the Neo4j class to return additional data.
    • Reformatted method for processing response data in the Neo4j class.

@gkorland gkorland marked this pull request as ready for review December 21, 2023 12:04
Copy link
Contributor

coderabbitai bot commented Dec 21, 2023

Warning

Rate Limit Exceeded

@gkorland has exceeded the limit for the number of files or commits that can be reviewed per hour. Please wait 3 minutes and 9 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 76c0c21 and eed1112.

Walkthrough

The recent update to the codebase primarily involves the integration of the logging module, replacing previous print statements. Additionally, method signatures and docstrings in certain classes have been reformatted for improved readability and consistency.

Changes

File(s) Summary
main.py Integrated logging module; replaced print statements with logging calls.
drivers/driver.py Reformatted method signatures and docstrings within the Driver class.
drivers/neo4j.py Modified the Neo4j class, including adjustments to method implementations.

🐇✨
To log or not to log, that was the question,
'Til prints were dethroned with a logging suggestion.
Now each little byte and each variable,
Is noted with care, in a log quite comparable. 🥕📜

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 6

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 8369a1c and 26e0bf3.
Files selected for processing (1)
  • main.py (6 hunks)
Additional comments: 2
main.py (2)
  • 3-3: The addition of import logging is correct and follows Python's convention for importing standard libraries.

  • 42-42: The use of logging.info after scraping text is appropriate for informational messages.

main.py Outdated Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
main.py Show resolved Hide resolved
gkorland and others added 2 commits December 21, 2023 14:07
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 5

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 26e0bf3 and 76c0c21.
Files selected for processing (2)
  • drivers/driver.py (2 hunks)
  • drivers/neo4j.py (6 hunks)
Files skipped from review due to trivial changes (1)
  • drivers/driver.py

drivers/neo4j.py Show resolved Hide resolved
drivers/neo4j.py Outdated Show resolved Hide resolved
drivers/neo4j.py Show resolved Hide resolved
drivers/neo4j.py Show resolved Hide resolved
drivers/neo4j.py Outdated Show resolved Hide resolved
gkorland and others added 7 commits December 21, 2023 14:09
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@isamu
Copy link
Collaborator

isamu commented Dec 21, 2023

Thank you for the good changes.

@isamu isamu merged commit 2edd470 into yoheinakajima:main Dec 21, 2023
1 check passed
@gkorland gkorland deleted the logger branch March 4, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants