Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ops(uninstall.sh): add optional removal of Docker-related components #888

Conversation

AnonymousWP
Copy link
Contributor

@AnonymousWP AnonymousWP commented Apr 18, 2023

Reason for this PR is that reNgine can take a lot of storage, especially after a long time. Even after running the previously existing uninstall.sh, a lot of storage could be saved (due to images and build cache).

Fixes #887

serrapa and others added 30 commits February 3, 2023 09:47
Rebase from yogeshojha/rengine
Fix yogeshojha#802 issue (Assetfinder results not created)
…g-for-one-liners-in-README

847 use inline code formatting for one liners in readme
The incorrect container names caused that the containers, volumes and networks weren't being removed as it requires the containers to be stopped
ops(`uninstall.sh`): fix incorrect container names
…e-string

fix(versioning): incorrect current release at login page
…e-string

fix(external_tools): incorrect theHarvester version
…e-string

fix(external_tools): specify command and path
@AnonymousWP AnonymousWP changed the title ops(uninstall.sh): add optional removal of images ops(uninstall.sh): add optional removal of images Apr 18, 2023
…moval-of-images-to-uninstall.sh-script

ops(`uninstall.sh`): add optional removal of Docker build cache
…moval-of-images-to-uninstall.sh-script

ops(`uninstall.sh`): remove 'unused' string
Prevents asking for confirmation twice
@AnonymousWP AnonymousWP changed the title ops(uninstall.sh): add optional removal of images ops(uninstall.sh): add optional removal of images and build cache Apr 18, 2023
@AnonymousWP AnonymousWP changed the title ops(uninstall.sh): add optional removal of images and build cache ops(uninstall.sh): add optional removal of Docker-related components Sep 6, 2023
@psyray
Copy link
Contributor

psyray commented Nov 17, 2023

@AnonymousWP Does this PR still relevant ?
There are so much commit inside this PR that seems to not be related with it.
Anyway it need to be rebased

@AnonymousWP
Copy link
Contributor Author

Yeah, because the PR is so old, I'll check later whether a new PR is needed or whether it's included in another pending PR. Leaving this open until I got the answer.

@AnonymousWP
Copy link
Contributor Author

I checked and I think it's better if I do this again after we merged #973 & #1007. Leaving it open for now until I created a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/2.1.0 Waiting for Merge Already Worked, waiting to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature - add optional removal of images to uninstall.sh script
4 participants