Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/stable containers #1250

Open
wants to merge 257 commits into
base: master
Choose a base branch
from
Open

Conversation

Talanor
Copy link
Contributor

@Talanor Talanor commented May 9, 2024

Hey,
here is a way of fixing the bug (and future bugs) due to conflicting packages.
Every standalone python tool is installed via pipx whenever possible, or packaged using poetry and a custom pyproject.toml file. Ideally those should be reported upstream, but if not possible, such files should be maintained here.

It also does several other things:

  • App containers now don't work in root.
  • Fix several hardcoded paths despite constants existing.

However it kind of goes against the "update whenever you want" mentality, hence the "removal" of several volumes. So opening this in draft for discussion / testing on how it could be better handled. That being said, I'm not sure everything works as intended in main on that front either.

psyray and others added 30 commits October 19, 2023 12:59
Co-authored-by: AnonymousWP <[email protected]>
yogeshojha and others added 27 commits May 12, 2024 18:59
feat: update to 2.0.6 from upstream
ops(install): fix rengine install/uninstall
docs(readme): fix links and images
# Create scan results dir
os.makedirs(scan.results_dir)
try:
os.makedirs(scan.results_dir, exist_ok=True)

Check failure

Code scanning / CodeQL

Uncontrolled data used in path expression High

This path depends on a
user-provided value
.
No idea where this file came from.
I assumed it was introduced by a MR, but apparently not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet