created better nav bar #14
Conversation
nityanandagohain
left a comment
nityanandagohain
left a comment
There was a problem hiding this comment.
I feel like the theme is not matching . The icons look too modern in a theme which is too simple .
|
We can also try changing the background to match it . |
| -ms-flex-pack: center; | ||
| justify-content: center; | ||
| -webkit-box-align: center; | ||
| -ms-flex-align: center; |
There was a problem hiding this comment.
i did it so that its easy for eyes to find things
| background-color: #f0f6ff; | ||
| border-radius: 0.25rem; | ||
| -webkit-box-shadow: 0 0.5rem 1rem rgba(0, 0, 0, .3); | ||
| box-shadow: 0 0.5rem 1rem rgba(0, 0, 0, .3); |
|
|
||
| .navigation a::after { | ||
| -webkit-box-shadow: 0 0.5rem 1rem rgba(0, 0, 0, .3); | ||
| box-shadow: 0 0.5rem 1rem rgba(0, 0, 0, .3); |
css/style.css
Outdated
| /* modules/navigation.css */ | ||
|
|
||
| .navigation { | ||
| background-color: #f0f6ff; |
There was a problem hiding this comment.
As @nityanandagohain said, It is looking a bit absurd upon the current color scheme. Can you change the color please?
Something like : rgba(255,255,255,0.4) Change the transparency according to need to get a beautiful looking bottombar
|
Ping @xeon-zolt |
|
Was little busy due to daily office work and exam will update by weekend
…On Tue 8 May, 2018, 11:03 PM Manish Devgan, ***@***.***> wrote:
Ping @xeon-zolt <https://github.com/xeon-zolt>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEUdIuM7UQQF5SW90oC8wt5BiO4UccUYks5twdbmgaJpZM4T0IZT>
.
|
|
@xeon-zolt I have a doubt in your code. Why do u have 5 (gitter,home,githhub,telegram,join) svg icons but only 4 slots? |
|
One of them is reserved for later commented now in case we add more pagea
…On Thu 10 May, 2018, 9:58 AM Ananthavijay, ***@***.***> wrote:
@xeon-zolt <https://github.com/xeon-zolt> I have a doubt in your code.
Why do u have 5 (gitter,home,githhub,telegram,join) svg icons but only 4
slots?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEUdIuOOjYmqt5DW7U_NR3usM5p0OwcOks5tw8HdgaJpZM4T0IZT>
.
|
|
@xeon-zolt I changed some things. check it here - https://codepen.io/Ananthavijay/pen/qYoWMv |
|
Looks nice let me replace nav with this
…On Thu 10 May, 2018, 11:15 AM Ananthavijay, ***@***.***> wrote:
@xeon-zolt <https://github.com/xeon-zolt> I changed some things. check it
here - https://codepen.io/Ananthavijay/pen/qYoWMv
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEUdIlfkI2fnb7KLRKj6B32CKMPsHzpvks5tw9QVgaJpZM4T0IZT>
.
|
|
Hey @xeon-zolt What if we add hover effect and colour changes for github,telegram and gitter. |
|
And desaturate the join icon too to make it look even
…On Thu 10 May, 2018, 11:28 AM Ananthavijay, ***@***.***> wrote:
Hey @xeon-zolt <https://github.com/xeon-zolt> What if we add hover effect
and colour changes for github,telegram and gitter.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEUdIskyY3URn1FWd0U4dzHaxxvMbI4Wks5tw9bvgaJpZM4T0IZT>
.
|
|
Yes..I will do it after half an hour |
|
Hey @xeon-zolt check this - https://codepen.io/Ananthavijay/pen/qYoWMv |
|
@xeon-zolt I have the existing join us logo which is desaturated. But I have no idea on how to add it 😄 . |
|
@xeon-zolt can u do the colour change on hover for the icons? |
|
This looks cool @Ananthavijay
|
|
I completed the colour change thing... What is the colour should I change to? |
|
completed the colour change effect.. check it here - https://codepen.io/Ananthavijay/pen/qYoWMv |
|
@gabru-md just approve this pr. i will create a new pr afterwards. 😄 |
|
@Ananthavijay or let me give you rights to make changes in my pr |
|
Anything is fine @xeon-zolt |
|
@Ananthavijay added your changes sorry i took little long |
|
@gabru-md @nityanandagohain I think the issue can be closed |
4 participants
Under construction 2 icons left
#10