Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Started best-practices.md #12

Merged
merged 1 commit into from
Jun 28, 2018
Merged

Started best-practices.md #12

merged 1 commit into from
Jun 28, 2018

Conversation

xeon-zolt
Copy link
Member

things learned from experiences and mistakes makes you better

gabru-md
gabru-md requested changes May 4, 2018
View reviewed changes
Copy link
Member

@gabru-md gabru-md left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we associate an issue with it, so that there can be a single PR for Best-Practices?
We can manage the ideas there and then this PR can be updated subsequently?

@xeon-zolt
Copy link
Member Author

or we can keep improving it one by one ?

@gabru-md
Copy link
Member

gabru-md commented May 4, 2018

But we do need an issue for the same I guess.
Where people can comment about what they consider to be among best practice

@xeon-zolt
Copy link
Member Author

@gabru-md sure create one please and link this with that issue

@gabru-md
Copy link
Member

gabru-md commented May 4, 2018

Link to Issue : #13

@xeon-zolt xeon-zolt merged commit cb97faa into yogdaan:master Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabru-md gabru-md gabru-md approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xeon-zolt @gabru-md