Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created morse.py #255

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Created morse.py #255

wants to merge 1 commit into from

Conversation

NachoNav
Copy link

Morse coder and decoder. Sorry if I messed something up, I'm not used to GitHub. 馃槥

Morse coder and decoder. Sorry if I messed something up, I'm not used to GitHub. 馃槥
@codecov-io
Copy link

Codecov Report

Merging #255 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #255   +/-   ##
======================================
  Coverage    77.4%   77.4%           
======================================
  Files          64      64           
  Lines        3842    3842           
======================================
  Hits         2974    2974           
  Misses        868     868

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 55fb70c...3a28cf7. Read the comment docs.

@manparvesh
Copy link
Member

manparvesh commented Mar 12, 2019

@NachoNav hi, thanks for the PR. It is preferred to have automated tests for every command you add. For more information on tests, look into the tests folder.
Also, going through the code, I don't think it will work. You can take a look at other modules to see how a command should be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants