Ignore key modifiers when handling keyboard events #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raushan
commented
Apr 20, 2024
Comment on lines
+294
to
+299
| * The set of modifers that will be checked to determine if a given key should | ||
| * be ignored when handling key events. | ||
| * | ||
| * Note that these correspond to `KeyboardEvent.key` values since `KeyboardEvent.getModifierState` | ||
| * does not accept `KeyboardEvent.code` values. | ||
| * @see {@link https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/getModifierState} |
There was a problem hiding this comment.
I mainly thought to point this out since EXCLUDED_KEY_BINDS uses KeyboardEvent.code values and I wanted to make it clear that these values are a bit different since they use KeyboardEvent.key values.
| * does not accept `KeyboardEvent.code` values. | ||
| * @see {@link https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/getModifierState} | ||
| */ | ||
| export const EXCLUDED_KEY_MODIFIERS = ["Alt", "Control", "Meta", "Shift"]; |
There was a problem hiding this comment.
I believe these modifiers are safe to ignore (i.e. ignoring them won't interfere with shorctuts) since they're all included in the set of keys that can't be used for key binds.
This helps to avoid accidentally activating a better-yt-shorts keyboard shortcut when trying to use a system/OS level shorcut.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds a set of modifiers that are be ignored when handling keyboard events to avoid accidentally activating better-yt-shorts shorcuts when trying to use system shortcuts.
For example, I noticed that pressing
cmd+f/ctrl+fto search for text on the page (e.g. comments on a yt short) also activates the full screen shortcut if you're using the default keybind.