Fix: Restore show in Kitsu Launcher action #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "Show in Kitsu" action was disabled. Updated code to work with latest server, and changed logic for getting URL to work with more Kitsu entity types (Edit, Sequence, shot etc.)
MustafaJafar
added
the
community
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Show in Kitsu" action was disabled. Updated code to work with latest server, and changed logic for getting URL to work with more Kitsu entity types (Edit, Sequence, shot etc.)
Changelog Description
Restore "Show in Kitsu" launcher action for tasks, folders, and projects
Additional review information
This uses Gazu to get task url, instead of creating this ourselves. Also using Gazu to get the type of the folder, when folders are selected. The type returned is always singular, while the URL we need is plural, eg. it returns "asset" while the URL should be "assets", so we need to add an "s" there. A bit weird, but it works.
When selecting a Project, or when something something goes wrong, we open the "Shots" page, as Kitsu does not have a home page for projects. Preferably this would respect the "Homepage" setting in Kitsu, or a similar one in Ayon settings, but was out of scope for now.
Testing notes: