Fix Hiero launching in macOS #100
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigRoy
added
type: bug
BigRoy
reviewed
Dec 9, 2025
Comment on lines
22
to
32
| menubar = [i for i in hiero_window.children() if isinstance( | ||
| i, | ||
| QtWidgets.QMenuBar | ||
| )] | ||
|
|
||
| # OSX fix - hiero_window.children() can't find menubars | ||
| if not menubar: | ||
| menubar = [hiero_window.menuBar()] | ||
|
|
||
| assert len(menubar) == 1, "Error, could not find menu bar!" | ||
| return menubar[0] |
Contributor
There was a problem hiding this comment.
Does return hiero_window.menuBar() not work also on Windows and Linux? Because if it does work - let's unify the behavior.
Suggested change
| return menubar[0] | |
| return hiero_window.menuBar() |
Contributor
There was a problem hiding this comment.
Hmm, somehow the suggestion doesn't seem to apply to all the lines - I guess it's clear what I mean :)
Author
There was a problem hiding this comment.
I tested on Linux and it works.
I don't know if I'm able to unify the code, so I simply added the fix instead 😅
I'm totally ok with you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
This PR fixes the launching of Hiero in macOS, because of a specific issue with Qt menu bars in this OS.
This bugfix is similar to Nuke.
Additional review information
Conversation in Ayon Forum: https://community.ynput.io/t/error-interpreting-this-plugin-nuke-osx/2730
Testing notes: