[WIP] Add lintprocessor #126
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymtdzzz
force-pushed
the
feature/lintprocessor
branch
from
a958d50 to
893f993
Compare
|
looks neat. I wonder if we shouldn't add a synthetic attribute for the semantic conventions version we are testing against? The version of the SDK and the version tested could be different (e.g. go.opentelemetry.io/otel/semconv) |
| @@ -68,15 +69,15 @@ service: | |||
| pipelines: | |||
| traces: | |||
| receivers: [otlp] | |||
| processors: [] | |||
| processors: [lint] | |||
There was a problem hiding this comment.
maybe make a flag for this as when you are developing a new semver, it may be clutter to see incompatabilities. I don't mind if it is on by default.
There was a problem hiding this comment.
I would love to one day have a choice like semver=1.27.0 (vs one before that) because it takes a month or two for some changes to break free. We don't need to take action here now though. Just a thought
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add lintprocessor to otel-tui. This processor is powered by otel-lint (WIP) and checks whether the received signals adhere to semantic conventions.
Currenlty, if there are any issues, it pushes
lint.*attributes to it.