Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplemented http_client using the ocurl library #127

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

carlonluca
Copy link
Contributor

This commit reimplements the http_client module by using the ocurl library. This should add support for the https protocol.

@carlonluca
Copy link
Contributor Author

The implementation is still a work in progress, which is the reason why it is a bit too verbose. This is the first patch needed to fix #119 and #41. Comments are welcome.

Copy link
Owner

@ygrek ygrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cursory review

This commit reimplements the http_client module by using the ocurl
library. This should add support for the https protocol.
Copy link
Owner

@ygrek ygrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, getting there
didn't review http_client.ml completely yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants