Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL-281] CSV export #464

Open
wants to merge 51 commits into
base: main
Choose a base branch
from
Open

[SQL-281] CSV export #464

wants to merge 51 commits into from

Conversation

kelvinqian00
Copy link
Collaborator

@kelvinqian00 kelvinqian00 commented Feb 11, 2025

Implement the exporting of all xAPI statements as CSV data. Both the CSV headers and the query params (based off the params for regular statement query) should be specified as parameters of the /admin/csv GET endpoint. Also adds a /admin/csv/auth endpoint to return a one-time JWT (since using /admin/csv as a download HTML anchor tag attribute means we cannot apply headers).

Adds a new LRSQL_STMT_GET_MAX_CSV to apply a limit to how many statements can be included in the CSV file.

TODO (for future tickets/PRs):

@kelvinqian00 kelvinqian00 marked this pull request as ready for review February 18, 2025 17:15
Copy link
Member

@milt milt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great, and I like the impl. Approved, pending the decision on where it goes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants