Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url-param auth POC #463

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

url-param auth POC #463

wants to merge 4 commits into from

Conversation

invaliduser
Copy link
Contributor

image

the mechanism here is a bit convoluted:

  • an interceptor is injected into the chain for the statements path specifically, that removes :credentialID from the :params map, and attaches it to a new key in the :request map: :com.yetanalytics.url-credential-ID. This has to be done here or else lrs will throw a fit credentialID not being in spec
  • LRS auth has a clause added that looks for :com.yetanalytics.url-credential-ID in the :request map, and, if it finds it, will query for the actual creds and modify the request so it passes Basic auth. However, I now think I can move this functionality into the interceptor and avoid muddying lrs.clj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant