Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL-264] JWT and Routing Enhancement Suite #456

Open
wants to merge 74 commits into
base: main
Choose a base branch
from

Conversation

kelvinqian00
Copy link
Collaborator

@kelvinqian00 kelvinqian00 commented Jan 14, 2025

Feature PR for JWT enhancement epic and support for frontend routing improvements.

Change Summary:

  • Add JWT refresh and logout revocation
  • Make /admin/ui the root path on FE, in order to support re-route
    • Ban users from setting /admin as the route prefix to avoid clashes
  • New endpoints:
    • /admin/account/logout: log out and invalidate current JWT by adding it to a blocklist
    • /admin/account/renew: renew the current JWT to extend the current login session
    • /admin/verify: returns 204 No Content if currently logged in
  • New config vars:
    • LRSQL_JWT_REFRESH_EXP_TIME: JWT refresh expiration time, after which refreshes can no longer be performed
    • LRSQL_JWT_REFRESH_INTERVAL: time interval for frontend to send a JWT refresh request
    • LRSQL_JWT_INTERACTION_WINDOW: time interval to check for user interaction before a potential JWT refresh

PRs:

kelvinqian00 and others added 26 commits November 11, 2024 12:34
Update base UI path to `/admin/ui`
[SQL-274] Prevent user from setting `LRSQL_URL_PREFIX` to `/admin`
Copy link
Member

@cliffcaseyyet cliffcaseyyet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through this pretty detailed and everything looks good. If it's been tested with noval and oidc this looks pretty ready to ship.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants