-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SQL-264] JWT and Routing Enhancement Suite #456
Open
kelvinqian00
wants to merge
74
commits into
main
Choose a base branch
from
jwt-enhancement-epic
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[SQL-267] `/admin/verify` endpoint
[SQL-222] Admin logout endpoint
[SQL-268] Admin JWT renewal endpoint
Update base UI path to `/admin/ui`
Development checklist
[SQL-274] Prevent user from setting `LRSQL_URL_PREFIX` to `/admin`
cliffcaseyyet
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through this pretty detailed and everything looks good. If it's been tested with noval and oidc this looks pretty ready to ship.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature PR for JWT enhancement epic and support for frontend routing improvements.
Change Summary:
/admin/ui
the root path on FE, in order to support re-route/admin
as the route prefix to avoid clashes/admin/account/logout
: log out and invalidate current JWT by adding it to a blocklist/admin/account/renew
: renew the current JWT to extend the current login session/admin/verify
: returns204 No Content
if currently logged inLRSQL_JWT_REFRESH_EXP_TIME
: JWT refresh expiration time, after which refreshes can no longer be performedLRSQL_JWT_REFRESH_INTERVAL
: time interval for frontend to send a JWT refresh requestLRSQL_JWT_INTERACTION_WINDOW
: time interval to check for user interaction before a potential JWT refreshPRs:
/admin/verify
endpoint #433/admin/ui
#439LRSQL_URL_PREFIX
to/admin
#449