Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Logback to 1.3.14 #353

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Update Logback to 1.3.14 #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdf3404
Fix maxLifetime to poolMaxLifetime in docs
kelvinqian00 Nov 30, 2023
d0c18b2
Update logback to 1.3.14
kelvinqian00 Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deps.edn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
danlentz/clj-uuid {:mvn/version "0.1.9"}
aero/aero {:mvn/version "1.1.6"}
selmer/selmer {:mvn/version "1.12.59"}
ch.qos.logback/logback-classic {:mvn/version "1.3.13"}
ch.qos.logback/logback-classic {:mvn/version "1.3.14"}
;; DB/JDBC deps
;; - HikariCP: Need to exclude slf4j to make logback work properly
;; - HugSql: Use custom version instead of the released version (0.5.1)
Expand Down
2 changes: 1 addition & 1 deletion doc/env_vars.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ The following environment variables are aliases for [HikariCP properties](https:

_NOTE 1:_ SQLite uses different defaults for `poolMinimumIdle` and `poolMaximumSize` than Postgres due to issues with multi-threading with those DBMSs. Setting `poolMaximumSize` to values other than `1` will potentially cause exceptions when running concurrent operations.

_NOTE 2:_ SQLite, while in in-memory mode, automatically deletes the database whenever the connection is removed, which can occur if a connection is closed and `maxLifetime` is exceeded. Thus, `maxLifetime` is set to `0`, denoting infinite connection lifetime, for convenience.
_NOTE 2:_ SQLite, while in in-memory mode, automatically deletes the database whenever the connection is removed, which can occur if a connection is closed and `poolMaxLifetime` is exceeded. Thus, `poolMaxLifetime` is set to `0`, denoting infinite connection lifetime, for convenience.

_NOTE 3:_ None of the DBMSs that SQL LRS currently supports allow for `TRANSACTION_NONE` as a `poolTransactionIsolation` value.

Expand Down