Feature/add file writer #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍👍👍thanks for your pr, I'll check later |
|
Maybe we don't need v2 package inside of the terminal, just keep them the same level, we name it as terminalv2 or another |
alexballas
force-pushed
the
feature/add_terminal_v2
branch
3 times, most recently
from
b2e6112
to
dfb08d4
Compare
alexballas
force-pushed
the
feature/add_terminal_v2
branch
from
0214b72
to
b8b0a29
Compare
|
will fix |
alexballas
force-pushed
the
feature/add_terminal_v2
branch
from
96b8160
to
9cfb350
Compare
|
hello @yeqown. I made the changes. Given that we dump the QRcode into a file I just named it file writer. |
yeqown
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.