Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -Wunused-parameter #13138

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Conversation

vvd170501
Copy link
Contributor

@vvd170501 vvd170501 commented Dec 30, 2024

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

This PR fixes -Wunused-parameter warning that is currently silenced. I'm going to restore this warning in the near future (https://nda.ya.ru/t/ysFv8tqj7Ao7Rm)

Copy link

Hi! Thank you for contributing!
The tests on this PR will run after a maintainer adds an ok-to-test label to this PR manually. Thank you for your patience!

@vvd170501 vvd170501 marked this pull request as ready for review December 31, 2024 01:14
@vvd170501 vvd170501 requested review from a team as code owners December 31, 2024 01:14
@vvd170501 vvd170501 force-pushed the fix-unused-parameter branch from 0716373 to ca0a247 Compare January 4, 2025 20:47
uzhastik
uzhastik previously approved these changes Jan 4, 2025
@vvd170501
Copy link
Contributor Author

vvd170501 commented Jan 4, 2025

I've rebased from d2c7d76 to 9740792, current;y trying to rebuild everything with -Wunused-parameter.
There still may be some warnings introduced by new commits, I'll ping when everything is fixed and the PR is ready for review.

@vvd170501
Copy link
Contributor Author

Fixed all warnings, waiting for approval.

@vvd170501 vvd170501 requested a review from uzhastik January 6, 2025 12:38
@vvd170501
Copy link
Contributor Author

@niksaveliev, could you review this PR or assign someone else?
I'm going to enable -Wunused-parameter in Arcadia in a few days, but I need to merge these fixes to enable it in opensource build.

uzhastik
uzhastik previously approved these changes Jan 6, 2025
@vvd170501
Copy link
Contributor Author

Rebased once more to fix merge conflicts in ydb/core/tx/columnshard/blobs_action/transaction/tx_blobs_written.cpp.

@uzhastik uzhastik added the rebase-and-check Rebase PR with the current base branch and check label Jan 8, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jan 8, 2025
@uzhastik uzhastik added the ok-to-test Special label used to approve a PR for testing on our infrastructure label Jan 8, 2025
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label Jan 8, 2025
Copy link

github-actions bot commented Jan 8, 2025

2025-01-08 12:30:08 UTC Pre-commit check linux-x86_64-release-asan for 7912bab has started.
2025-01-08 12:30:19 UTC Artifacts will be uploaded here
2025-01-08 12:33:14 UTC ya make is running...
🟡 2025-01-08 13:39:13 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12659 12580 0 45 5 29

2025-01-08 13:40:17 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-08 13:51:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
135 (only retried tests) 98 0 9 1 27

2025-01-08 13:51:57 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-08 14:03:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67 (only retried tests) 37 0 3 2 25

🟢 2025-01-08 14:03:49 UTC Build successful.
🟢 2025-01-08 14:04:21 UTC ydbd size 3.6 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 96abd52 merge: 7912bab diff diff %
ydbd size 3 873 655 368 Bytes 3 873 655 272 Bytes -96 Bytes -0.000%
ydbd stripped size 1 350 627 952 Bytes 1 350 627 888 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 8, 2025

2025-01-08 12:30:16 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7912bab has started.
2025-01-08 12:30:28 UTC Artifacts will be uploaded here
2025-01-08 12:33:34 UTC ya make is running...
🟡 2025-01-08 13:28:18 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26580 24067 0 5 2383 125

2025-01-08 13:30:40 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-08 13:42:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
192 (only retried tests) 70 0 1 0 121

2025-01-08 13:42:34 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-01-08 13:54:00 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
178 (only retried tests) 57 0 0 0 121

🟢 2025-01-08 13:54:07 UTC Build successful.
🟢 2025-01-08 13:54:31 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 96abd52 merge: 7912bab diff diff %
ydbd size 2 244 213 440 Bytes 2 244 213 440 Bytes 0 Bytes 0.000%
ydbd stripped size 472 322 416 Bytes 472 322 416 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@maximyurchuk maximyurchuk merged commit 6f59478 into ydb-platform:main Jan 8, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants