New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update package config #1448
base: develop
Are you sure you want to change the base?
Conversation
Fixing Bug Report ydataai#1384 Dataset with categorical features causes memory error even on tiny dataset.
d6e6a2e
to
754d0a5
Compare
7e1c52f
to
e7777b5
Compare
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1448 +/- ##
===========================================
+ Coverage 89.49% 89.53% +0.04%
===========================================
Files 194 194
Lines 6318 6316 -2
===========================================
+ Hits 5654 5655 +1
+ Misses 664 661 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Co-authored-by: Fabiana <[email protected]>
Hi @vorel99 , once again than you for your contribution :) I've already requested the review from the team! |
* Update javascript.html * Update style.html
Hi @vorel99. Thank you for your work in the migration to |
365613f
to
8373d2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything else seems fine to me. @portellaa, what do you think?
hello, |
6a3342a
to
8f4f622
Compare
Hi @vorel99 Thanks for your PR. Unfortunately we don't have the time right now to move forward with this, we kindly ask you to give us some more time. Sorry for this. Cheers |
Thanks for reply @portellaa, I can rebase my branch to new develop, when you are ready. Regards, |
In python world, new standard for package configuration is
pyproject.toml
. So I moved all static config fromsetup.py
topyproject.toml
.setup.py
topyproject.toml
Makefile
install_dev
: install all requirements for pandas development and testinginstall_test_pandas
: install ydata-profiling with optional dependencies for testinginstall_test_spark
: install ydata-profiling with optional dependencies for testing sparkrequirements
filesrequirements
files usage