Skip to content

Commit

Permalink
remove tmux dependency and also disable libyui tests
Browse files Browse the repository at this point in the history
  • Loading branch information
jreidinger committed Jan 22, 2025
1 parent ea82077 commit 852f09c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 15 deletions.
11 changes: 0 additions & 11 deletions package/yast2-ruby-bindings.spec
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,6 @@ BuildRequires: s390-tools
Requires: s390-tools
%endif


# The test suite includes a regression test (std_streams_spec.rb) for a
# libyui-ncurses bug fixed in 2.47.3
BuildRequires: libyui-ncurses >= 2.47.3
# The mentioned test requires tmux in order to be executed in headless systems
# Also many other libyui tests to come
BuildRequires: tmux

# only a soft dependency, the Ruby debugger is optional
Suggests: rubygem(%{rb_default_ruby_abi}:byebug)

Expand Down Expand Up @@ -96,9 +88,6 @@ make install DESTDIR=$RPM_BUILD_ROOT
cd -

%check
# Build workers are set up without systemd so the default /run/tmux dir
# will not be present (unless clamav pulls systemd in, on SLE)
export TMUX_TMPDIR=/tmp
cd build
make test ARGS=-V
cd -
Expand Down
10 changes: 6 additions & 4 deletions tests/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@ endforeach(test)
# ADD_TEST("integration" ruby ${CMAKE_CURRENT_SOURCE_DIR}/integration/run.rb)
ADD_TEST("translations" rspec --format doc ${CMAKE_CURRENT_SOURCE_DIR}/integration/translations_spec.rb)

file(GLOB libyui_specs "libyui/*_spec.rb")
foreach(test ${libyui_specs})
ADD_TEST(${test} rspec --format doc ${test})
endforeach(test)
# disable also libyui tests as it is too fragile on non intel architectures and it is not ruby-bindings job to test it
# if wanted, it can live separately.
# file(GLOB libyui_specs "libyui/*_spec.rb")
# foreach(test ${libyui_specs})
# ADD_TEST(${test} rspec --format doc ${test})
# endforeach(test)

0 comments on commit 852f09c

Please sign in to comment.