Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo when modifying the initiatorname. #139

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Fix typo when modifying the initiatorname. #139

merged 2 commits into from
Nov 14, 2024

Conversation

teclator
Copy link
Contributor

Problem

Fix typo introduced by #136

Testing

  • Tested manually

@coveralls
Copy link

coveralls commented Nov 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11834173013

Details

  • 0 of 7 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 28.866%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/include/iscsi-client/widgets.rb 0 7 0.0%
Totals Coverage Status
Change from base Build 11794857990: 0.0%
Covered Lines: 728
Relevant Lines: 2522
💛 - Coveralls

ancorgs
ancorgs approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry for overlooking, but the changes were huge and this was in a log.info. 🤷🏿‍♂️

@teclator teclator merged commit 7b55ada into SLE-15-SP6 Nov 14, 2024
10 checks passed
@teclator teclator deleted the fix_typo branch November 14, 2024 09:32
@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #9 successfully finished
✔️ Created IBS submit request #353628

@teclator teclator mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ancorgs ancorgs ancorgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@teclator @coveralls @yast-bot @ancorgs