Migrates to Eslint's flat config #6276
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Draft until #6219 is fixed. |
clemyan
reviewed
May 7, 2024
Comment on lines
+9
to
+41
| ignores: [ | ||
| `.yarn`, | ||
|
|
||
| `packages/docusaurus/.docusaurus`, | ||
|
|
||
| `packages/yarnpkg-pnp/sources/hook.js`, | ||
| `packages/yarnpkg-pnp/sources/esm-loader/built-loader.js`, | ||
|
|
||
| `packages/yarnpkg-libzip/sources/libzipAsync.js`, | ||
| `packages/yarnpkg-libzip/sources/libzipSync.js`, | ||
|
|
||
| // The parsers are auto-generated | ||
| `packages/yarnpkg-parsers/sources/grammars/*.js`, | ||
|
|
||
| `packages/yarnpkg-core/sources/worker-zip/index.js`, | ||
| `packages/yarnpkg-cli/bundles/yarn.js`, | ||
|
|
||
| `packages/*/lib`, | ||
| `packages/*/bin`, | ||
| `packages/*/build`, | ||
| `packages/**/*fixtures*`, | ||
| `packages/yarnpkg-libzip/artifacts`, | ||
| `packages/plugin-compat/extra/fsevents/fsevents-*.js`, | ||
|
|
||
| // Files generated by Gatsby | ||
| `packages/gatsby/public`, | ||
| // Files generated by TypeDoc`, | ||
| `packages/gatsby/static/api`, | ||
|
|
||
| // Minimize the diff with upstream`, | ||
| `packages/yarnpkg-pnp/sources/node`, | ||
| `packages/yarnpkg-pnp/sources/loader/node-options*` | ||
| ], |
There was a problem hiding this comment.
- The gatsby rules should be safe to remove
- Is
yarnpkg-clithe only workspace to generate abundledirectory? Because other places just ignorespackages/*/bundle - Should the
yarnpkg-libuiartifacts also be here? - Should the these be grouped by package?
|
FYI, ESLint recently released the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
This lets us remove the Rushstack fix, and dogfood the VSCode SDK with the flat config (which is the only available config in Eslint 9). I would have migrated us to Eslint 9, but eslint-plugin-react isn't compatible yet.
How did you fix it?
Migrate to eslint.config.mjs.
Checklist