Fix two formatting issues on Contributing page #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://yargs.js.org/contributing/ had two visible issues: - There was a space before the comma in “Create a new issue , or comment on an existing issue”. This was due to the practice of writing all `a` elements with inner spaces. I removed all such inner spaces to avoid this problem in the future. - There was an unnecessary comma after a sentence: “write code. ,” I also deeleted some unnecessary blank lines at the bottom.
shadowspawn
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://yargs.js.org/contributing/ had two visible issues:
aelements with inner spaces. I removed all such inner spaces to avoid this problem in the future.I also deleted some unnecessary blank lines at the bottom.
I did not try rebuilding the repo with Jekyll; I just edited this one file in the web editor. I don’t see any other source files for the Contributing page, though, so I think this should work.