Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull request for until expert #1

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

EBUCILONG
Copy link

2.19 (Bowen)

Added the support of parsing repeat-until.
The index of first expert of Tr is stored as the first element of until's params.
Changed file:

  • core/parser.cpp
  • core/parser.hpp
  • base/type.hpp added until to expert_t

2.20 (Shiyuan)

Added file:

  • expert/until_expert.hpp

Changed file:

  • core/type.hpp
  • core/message.cpp changed update_route function
  • core/message.cpp add his_index to meta
  • core/message.cpp modified dispatch_data for until_spawn

2.22 (Shiyuan)

Changed file:

  • core/until_expert.hpp fix process_spawn function
  • core/message.cpp modified dispatch_data to make use of his_index

2.23 (Bowen)

Changed file:

  • expert/until_expert.hpp add the process_branch function

2.25 (Bowen)

Changed file:

  • expert/until_expert.hpp fix typo and comment on process_spawn

@yaobaiwei yaobaiwei closed this Feb 28, 2020
yaobaiwei added a commit that referenced this pull request Dec 23, 2020
[Enhancement][New Query Step][add functional support for Gremlin query step: repeat...until]
@yaobaiwei yaobaiwei reopened this Apr 3, 2021
@yaobaiwei
Copy link
Owner

@BowenforGit Hi, Bowen, I reopen this PR because actually yr PR included some bugs which led to compilation error after I merged into our master branch, looks like you even didn't compile the code for testing before you PR, and we didn't set CI for Grasper. Please see more details in Issue4. And because you've deleted the source branch, I cannot revert the commit directly via the button. I will revert it manually to make repo work correctly. Please address well where the problems are (e.g. { "until": UNTIL }) and re-post it if you have time later.

@yaobaiwei yaobaiwei closed this Apr 3, 2021
@BowenforGit
Copy link
Contributor

BowenforGit commented Apr 3, 2021 via email

@yaobaiwei yaobaiwei reopened this Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants