-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pull request for until expert #1
base: master
Are you sure you want to change the base?
Conversation
…y step: repeat...until]
[Enhancement][New Query Step][add functional support for Gremlin query step: repeat...until]
@BowenforGit Hi, Bowen, I reopen this PR because actually yr PR included some bugs which led to compilation error after I merged into our master branch, looks like you even didn't compile the code for testing before you PR, and we didn't set CI for Grasper. Please see more details in Issue4. And because you've deleted the source branch, I cannot revert the commit directly via the button. I will revert it manually to make repo work correctly. Please address well where the problems are (e.g. |
Hi Hongzhi,
Thanks for letting me know. Shiyuan and I will investigate it recently.
…On Sat, Apr 3, 2021 at 1:32 PM Hongzhi Chen ***@***.***> wrote:
@BowenforGit <https://github.com/BowenforGit> Hi, Bowen, I reopen this PR
because actually yr PR included some bugs which led to compilation error
after I merged into our master branch, looks like you even didn't compile
the code for testing before you PR, and we didn't set CI for Grasper.
Please see more details in Issue4
<#4>. And because you've
deleted the source branch, I cannot revert the commit directly via the
button. I will revert it manually to make repo work correctly. Please
address well where the problems are (e.g. { "until": UNTIL }) and re-post
it if you have time later.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIK4ELB3CXDVBMDICU5DXEDTG34FDANCNFSM4K4GK3CQ>
.
|
2.19 (Bowen)
Added the support of parsing repeat-until.
The index of first expert of Tr is stored as the first element of until's params.
Changed file:
2.20 (Shiyuan)
Added file:
Changed file:
2.22 (Shiyuan)
Changed file:
2.23 (Bowen)
Changed file:
2.25 (Bowen)
Changed file: