Skip to content

Commit

Permalink
app: Improve play button tooltips
Browse files Browse the repository at this point in the history
The tooltip for the 'Start playback' button is somewhat misleading.

```tooltip-text: _("Start/Stop playback");```

This button not only starts the playback but also pauses it.

It was already declared in the accessibility string.

```
          accessibility {
            label: _("Start or pause the playback");
          }
```

The tooltip for this button should be something like the following strings:

- Toggle Playback
- Start/Stop playback
- Start/Stop
  • Loading branch information
yakushabb committed Apr 17, 2024
1 parent f797496 commit e61cdf1
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
5 changes: 4 additions & 1 deletion data/ui/album_element.blp
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,13 @@ template $AlbumElement: Box {
height-request: 40;
focusable: true;
focus-on-click: false;
tooltip-text: _("Play");
tooltip-text: _("Start/Stop playback");
halign: center;
valign: center;
icon-name: 'media-playback-start-symbolic';
accessibility {
label: _("Start or pause the playback");
}

styles [
"circular",
Expand Down
4 changes: 4 additions & 0 deletions data/ui/book_detail.blp
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,10 @@ template $BookDetail: Box {
receives-default: true;
halign: center;
icon-name: 'media-playback-start-symbolic';
tooltip-text: _("Start/Stop playback");
accessibility {
label: _("Start or pause the playback");
}

styles [
"suggested-action",
Expand Down
2 changes: 1 addition & 1 deletion data/ui/media_controller.blp
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ template $MediaController: Adw.BreakpointBin {
height-request: 42;
focusable: true;
receives-default: true;
tooltip-text: _("Start playback");
tooltip-text: _("Start/Stop playback");
halign: center;
valign: center;
icon-name: 'media-playback-start-symbolic';
Expand Down

0 comments on commit e61cdf1

Please sign in to comment.