Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#147] Crash Fix for Optionals in UserDefaultsStore #151

Merged
merged 4 commits into from
May 13, 2024
Merged

[#147] Crash Fix for Optionals in UserDefaultsStore #151

merged 4 commits into from
May 13, 2024

Conversation

yakovmanshin
Copy link
Owner

[Closes #147]

  • UserDefaults does not accept nil as the value in a record
  • Upon finding a nil, UserDefaults raises an exception which crashes the client app
  • This fix does not add complete support for optionals but addresses the crash by checking the type against the ExpressibleByNilLiteral protocol and throwing the optionalValuesAreNotSupported error
  • Complete support for optionals in UserDefaultsStore is planned for Complete support for optional values in UserDefaultsStore #150

@yakovmanshin yakovmanshin added the bug Something isn’t working label May 13, 2024
@yakovmanshin yakovmanshin added this to the v4.0.0 milestone May 13, 2024
@yakovmanshin yakovmanshin self-assigned this May 13, 2024
@yakovmanshin yakovmanshin enabled auto-merge (squash) May 13, 2024 00:37
@yakovmanshin yakovmanshin mentioned this pull request May 13, 2024
Open
@yakovmanshin yakovmanshin merged commit 6121eff into main May 13, 2024
7 checks passed
@yakovmanshin yakovmanshin deleted the 147-optionals-in-UserDefaultsStore branch May 13, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yakovmanshin yakovmanshin

Labels
bug Something isn’t working
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

UserDefaultsStore does not support nil values
1 participant
@yakovmanshin