changed keyboard input to multilingual #402
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Dec 19, 2023
GermanHydrogen
requested changes
Jan 9, 2024
| _consoleOutput ctrlSetStructuredText (composeText _output); | ||
|
|
||
| private _consoleInput = _consoleOutput getVariable ["AE3_consoleInput", controlNull]; | ||
| ctrlSetFocus _consoleInput; |
There was a problem hiding this comment.
Why do we need to set the focus again?
If this is important, please add a comment
There was a problem hiding this comment.
@GermanHydrogen The focus changes in cases where the player clicks on other UI elements like the buttons in the header. I don't think that it's strictly necessary but this way we ensure that the focus is on the input field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging this pull request will change the keyboard input. It's now handled via an invisible input text field that processes the input independently fromt the used keyboard layout. Then I copy the resulting characters to our terminal buffer. Now there is no need anymore for the corresponding CBA setting and switching keyboard layouts. All code belonging to keyboard switching was removed.
I still need to check how this will behave for eastern users like chinese and how do they input via the IME