feat(dx-improve): Added modifications in auth.tsx and server.ts to handle missing .env variables when running quickstart. #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oindrila-b
changed the title
zereraz
reviewed
Jan 31, 2025
| @@ -214,6 +214,21 @@ const generateToken = async ( | |||
| const jwtToken = await sign(payload, jwtSecret) | |||
| return jwtToken | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
hmm a separate route to handle if .env is setup correctly or not.
any alternative like in the get user call itself sending metadata about the setup if user is admin role and above?
… when executing quickstart
zereraz
force-pushed
the
missing-env-handling
branch
from
9a2338d to
f2a1374
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FEATURE PR: Previously our app would redirect to a404 Not Foundscreen when the user would try to login without setting the Google Credentials. To improve the user experience, we added a prompt that shows aConfiguration Errorwhen the user tries to login without having set the Google Credentials. This is a better user experience than a 404 screen.Testing
Tested locally without setting .env variables and running quickstart.
Additional Notes
No notes so far.