Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update get-nodes-bounds.mdx #747

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update get-nodes-bounds.mdx #747

wants to merge 2 commits into from

Conversation

dimaMachina
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Apr 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
example-apps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 6, 2025 3:29am
ui-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 6, 2025 3:29am
xyflow-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 6, 2025 3:29am

@vercel Vercel
Copy link

vercel bot commented Apr 5, 2025

@dimaMachina is attempting to deploy a commit to the xyflow Team on Vercel.

A member of the Team first needs to authorize it.

printerscanner
printerscanner reviewed Apr 7, 2025
View reviewed changes
sites/reactflow.dev/src/content/api-reference/utils/get-nodes-bounds.mdx
<Callout type="info" emoji="ℹ️">
This function was previously called `getRectOfNodes`
</Callout>
> [!NOTE]
Copy link
Member

@printerscanner printerscanner Apr 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this is better, but I think this should probably stay as a Callout so it matches the other ones?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nextra replace github alert syntax with callout component https://nextra.site/docs/guide/github-alert-syntax#example

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but we should probably pick one or the other for every single time a callout is used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, GitHub alert syntax is preferable since while editing a file in GitHub you have a nice callout too
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@printerscanner printerscanner printerscanner left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimaMachina @printerscanner