Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pass general data to custom hotkey configs #540

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Heck-R
Copy link

@Heck-R Heck-R commented Apr 16, 2023

Hi, I love the possibility of custom configurations, but only site-specific ones seem to get detailed info on what's happening.
So this change is just that. It's a bit different from the site-specific one because this one is missing the player, but as the h5Player has an equivalent property it should not be necessary

I did not update the dist as I was not sure if I was supposed to be (I was also not sure how to do it properly)
To be fair this is more of a feature request than a pull request, I just implemented it so that I can use it immediately, and I thought I'd create a pull request from it in case it's of any help

Google Translated Chinese:
嗨,我喜欢自定义配置的可能性,但似乎只有特定于站点的配置才能获得有关正在发生的事情的详细信息。
所以这个变化就是这样。它与特定于站点的有点不同,因为这个缺少播放器,但由于 h5Player 具有等效属性,因此没有必要

我没有更新 dist,因为我不确定我是否应该更新(我也不确定如何正确地做)
公平地说,这更像是一个功能请求而不是拉取请求,我只是实现了它以便我可以立即使用它,我想我会从中创建一个拉取请求以防它有任何帮助

@Heck-R
Copy link
Author

Heck-R commented Mar 17, 2024

A specific example where I find this to be necessary/useful is overwriting the volume change from linear to "relative" (meaning the volume always changes by 10%, which is more consistent to the ears and is handy for lower volumes)
It gives consistently high level of customizability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant