fix(runtime-dom): use Symbol value for checkbox true-value vuejs#10597

xw616525957 · Mar 28, 2024 · a127b8d · a127b8d
1 parent db374e5
commit a127b8d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/packages/runtime-dom/__tests__/patchAttrs.spec.ts b/packages/runtime-dom/__tests__/patchAttrs.spec.ts
@@ -53,4 +53,12 @@ describe('runtime-dom: attrs patching', () => {
  patchProp(el, 'onwards', 'a', null)
  expect(el.getAttribute('onwards')).toBe(null)
  })
+
+ // #10597
+ test('should allow setting attribute to symbol', () => {
+ const el = document.createElement('div')
+ const symbol = Symbol('foo')
+ patchProp(el, 'foo', null, symbol)
+ expect(el.getAttribute('foo')).toBe(symbol.toString())
+ })
 })
diff --git a/packages/runtime-dom/src/modules/attrs.ts b/packages/runtime-dom/src/modules/attrs.ts
@@ -36,7 +36,8 @@ export function patchAttr(
  if (value == null || (isBoolean && !includeBooleanAttr(value))) {
  el.removeAttribute(key)
  } else {
- el.setAttribute(key, isBoolean ? '' : value)
+ // attribute value is a string https://html.spec.whatwg.org/multipage/dom.html#attributes
+ el.setAttribute(key, isBoolean ? '' : String(value))
  }
  }
 }