Make compatiblewith an URI and improve description #281
Conversation
|
didn't you want to make this a top-level optional attribute instead of a label? |
I did the change now. Also added it to the As URI, I went with the github raw file links |
| }, ? | ||
| "createdat": "TIMESTAMP", | ||
| "modifiedat": "TIMESTAMP", | ||
| "modelversion": "1.0", ? |
There was a problem hiding this comment.
this needs to be "STRING"
and the next one "URI"
because at this point in the spec we're just defining the abstract model. I don't think we want to imply that these are the values they MUST be for all implementations.
Also, I think these needs to be under "model", not at the root of the registry
| @@ -3,6 +3,8 @@ | |||
| "endpoints": { | |||
| "singular": "endpoint", | |||
| "plural": "endpoints", | |||
| "modelversion": "1.0", | |||
There was a problem hiding this comment.
| "modelversion": "1.0", | |
| "modelversion": "0.5", |
Signed-off-by: Simon Heimler <[email protected]>
Signed-off-by: Simon Heimler <[email protected]>
Signed-off-by: Simon Heimler <[email protected]>
Signed-off-by: Simon Heimler <[email protected]>
Signed-off-by: Simon Heimler <[email protected]>
Signed-off-by: Simon Heimler <[email protected]>
Signed-off-by: Simon Heimler <[email protected]>
Fannon
force-pushed
the
improve-compatiblewith-description
branch
from
d6302bf to
dfde835
Compare
|
|
||
| - Constraints: | ||
| - OPTIONAL. | ||
| - Only applicable on model definition. |
There was a problem hiding this comment.
you can delete the above line
|
|
||
| - Constraints: | ||
| - OPTIONAL. | ||
| - Only applicable on model definition. |
There was a problem hiding this comment.
you can delete the above line
| - Only applicable on model definition. | ||
| - Does not imply runtime validation of the claim. | ||
|
|
||
| - examples: |
| "modelversion": "1.0", ? | ||
| "compatiblewith": "https://github.com/xregistry/spec/blob/main/schema/spec.md", ? | ||
| "STRING": "STRING" * | ||
| "STRING": "STRING" * |
Fixes #276
TODO