Week of March 3 #269
Merged
Week of March 3 #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duglin
force-pushed
the
Mar3
branch
5 times, most recently
from
d660eb0 to
ef1654e
Compare
jskeet
reviewed
Mar 5, 2025
core/primer.md
Outdated
|
|
||
| The `ifvalues` feature might be a new concept for some readers, so a point | ||
| of clarification might be useful. If an attribute is defined with an `ifvalues` | ||
| apect, then if that attribute's value changes it is posisble that the |
There was a problem hiding this comment.
Suggested change
| apect, then if that attribute's value changes it is posisble that the | |
| aspect, then if that attribute's value changes it is possible that the |
core/spec.md
Outdated
| `relaxednames` aspect to `true` the server MUST allow for an extended | ||
| set of valid characters in attribute names for this object. | ||
|
|
||
| The allowable characters for `relaxednames` object's attributes are: |
There was a problem hiding this comment.
In any position, so "0" and "-0" are both valid names? That feels potentially more relaxed than we'd want - perhaps require a-z to start with?
There was a problem hiding this comment.
done - I actually missed some other chars too. You should refresh before you review more to make sure you see the latest
- fix typos in doc/contributors.md - get rid of `clientrequired` and rename `serverrequired` to just `required`. It now means "this attr MUST have a non-null value" without saying who provides it. - mentioned we're http-only today but it might change in the future, and at that time we'll have a clean separation between core & http - Add an "Implmentation Customizations" section to talk about adding authN/Z and other types of customization logic - Allow ANY model changes as long as all entities are compliant with new model prior to completing the request. Server MAY choose to update data, or reject. - Remove "maxmaxversions" capability - Servers must accept "0" for maxversions but can prune at any time, even at 1. - Add "relaxednames" aspect to "object" typed attributes, to allow "-" in names. And updated our model files to use "-" in some attribute names Fixes: xregistry#267 Fixes: xregistry#230 Fixes: xregistry#264 Fixes: xregistry#270 Fixes: xregistry#271 Fixes: xregistry#273 Fixes: xregistry#272 Signed-off-by: Doug Davis <[email protected]>
jskeet
approved these changes
Mar 6, 2025
|
Approved on the 3/6 call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clientrequiredand renameserverrequiredto justrequired.It now means "this attr MUST have a non-null value" without saying who
provides it.
that time we'll have a clean separation between core & http
and other types of customization logic
prior to completing the request. Server MAY choose to update data, or reject.
Fixes: #267
Fixes: #230
Fixes: #264
Fixes: #270
Fixes: #271
Fixes: #273
Fixes: #272