Add EEPROM image generator #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Any chance you can add build instructions to the readme? |
JayFoxRox
reviewed
May 8, 2020
eepromgen.c
Outdated
|
|
||
| int main() { | ||
| size_t i; | ||
| FILE* eepromFile = fopen("./eeprom.bin", "wb"); |
There was a problem hiding this comment.
Avoid the ./ prefix. It will break some platforms.
JayFoxRox
reviewed
May 8, 2020
eepromgen.c
Outdated
| fwrite(default_eeprom, 1, 256, eepromFile); | ||
| fclose(eepromFile); | ||
| } else { | ||
| printf("Opening eeprom.bin for write failed!\n"); |
JayFoxRox
reviewed
May 8, 2020
eepromgen.c
Outdated
| fwrite(default_eeprom, 1, 256, eepromFile); | ||
| fclose(eepromFile); | ||
| } else { | ||
| printf("Opening eeprom.bin for write failed!\n"); |
There was a problem hiding this comment.
nit: I'd suggest to have const char* path = "eeprom.bin"; for the fopen(path, "wb") and then use "Creating '%s' failed.", path
JayFoxRox
reviewed
May 8, 2020
eepromgen.c
Outdated
| size_t i; | ||
| FILE* eepromFile = fopen("./eeprom.bin", "wb"); | ||
| if (eepromFile) { | ||
| fwrite(default_eeprom, 1, 256, eepromFile); |
There was a problem hiding this comment.
This could should check if all 256 bytes were written probably.
At very least an assert would be good
JayFoxRox
reviewed
May 8, 2020
eepromgen.c
Outdated
| }; | ||
|
|
||
| int main() { | ||
| size_t i; |
There was a problem hiding this comment.
Right, not sure why I added that one in the first place. Has since been removed.
JayFoxRox
reviewed
May 8, 2020
eepromgen.c
Outdated
| #include <stddef.h> | ||
|
|
||
| /* Bunnies eeprom */ | ||
| const unsigned char default_eeprom[] = { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in xqemu/xqemu-manager#57 , here comes an EEPROM image (generator).