Make pip installable and add CLI entrypoints #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I took the liberty to put a few classifiers as well.
|
How unfortunate that the authors have abandoned their work. Thank you for your efforts @cthoyt! Btw perhaps you managed to pin down the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #5 by putting the code in a directory structure that's required by python packages, by adding a minimal
setup.py/setup.cfg.It also closes #6 by encapsulating the main functionality (that used to live under the
if __name__ == '__main__'block) with functions, then by adding the[options.entry_points]header tosetup.cfg.I also added an example in the README on how to run the code on one of the examples presented in your paper. I'm a big fan of DeepWalk and related methods, and I appreciate the incredible work you did to push the theoretical side of it. I hope this PR is helpful for you, and many others!