Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to upgrade three.js r150.
describe
Removed the
THREE.Geometry.prototype.toFlatShading
method and usedflatShading
for material. TBH, I am not sure it was right.Refactor the code with ES modules.
Created
createInstancedMesh
method forScene*Module.js
, because of duplicate code.If the PR has any problem, please tell me.
online preview link: https://linbingquan.github.io/obsidian/