Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some mild renames in (just one) Pact test #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

tobyweston
Copy link
Member

@tobyweston tobyweston commented Jun 6, 2019

Trying to clarify the intent within the test.

Just a suggestion, if we like it collectively we should run through more files. This is a single file to communicate - I don't expect anyone to merge the PR instead feel free to comment to the changes / start a "review" within Github.

Sidebar I also have an issue with (not our decision) that Pact calls their server a "mock" (see
cc2138d). It doesn't feel like a formal mock (as in 'mocks vs stubs'). It's actually a real HTTP server running with stubed responses now? Unless I'm missing something, it's basically wiremock no?

@tobyweston tobyweston closed this Jun 8, 2021
@tobyweston tobyweston reopened this Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant