EWMH: support _NET_WM_STATE_{ABOVE,BELOW} #968
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for NET_WM_STATE{ABOVE,BELOW}. This includes both a manage hook to handle states that are put at the start and an event handler for ClientMessageEvent.
I am not sure where to exactly hook into the hooks (not particularly proud with how I added the handle event hook), so ideas are welcome. Maybe I could do a small refactoring for the module first? Not sure
Checklist
I've read CONTRIBUTING.md
I've considered how to best test these changes (property, unit,
manually, ...) and concluded: Wrote a small python script that would switch between the states (using add, remove, and toggle) and observed the
_NET_WM_STATEwithxprop -spyand how the window behavedCHANGES.mdfile