Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code optimizations NULL checks #48

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

selvamKrish
Copy link

As part of this code optimization,

  • Added NULL checks before doing any string operation and free
  • Replaced malloc with strdup

@codecov
Copy link

codecov bot commented Aug 1, 2018

Codecov Report

Merging #48 into master will decrease coverage by 1.99%.
The diff coverage is 34.9%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #48   +/-   ##
=======================================
- Coverage   90.41%   88.41%   -2%     
=======================================
  Files           3        3           
  Lines        1888     1917   +29     
  Branches      201      226   +25     
=======================================
- Hits         1707     1695   -12     
- Misses         57       74   +17     
- Partials      124      148   +24
Impacted Files Coverage Δ
tests/simple.c 93.39% <100%> (-0.04%) ⬇️
src/wdmp_internal.c 80.3% <33.33%> (-5.94%) ⬇️
src/wdmp-c.c 73.03% <8.33%> (-4.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c972e99...3b0a9ff. Read the comment docs.

@shilpa24balaji shilpa24balaji changed the title Code optimization as part of https://ccp.sys.comcast.net/browse/XMIDT-404 Code optimizations NULL checks Oct 11, 2018
@CLAassistant
Copy link

CLAassistant commented Aug 2, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants