Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: unify dictionaryid #1446

Open
wants to merge 1 commit into
base: experimental
Choose a base branch
from
Open

Conversation

xiaoyifang
Copy link
Owner

@xiaoyifang xiaoyifang commented Mar 27, 2024

benefit :
you can move your dictionary files into other folders and have no need to reindex the dictionary again.

drawback:
If you have two versions of the same dictionary , only the first one got indexed.

Copy link

sonarcloud bot commented Mar 27, 2024

@shenlebantongying shenlebantongying added the vNext Improvments and optimizations that need incompatible changes. label May 25, 2024
@GD-fix
Copy link

GD-fix commented Jun 1, 2024

drawback:
If you have two versions of the same dictionary , only the first one got indexed.

What "two versions" means here: the same content and name dictionary files on two different locations, only the same name dictionary files on two different locations, only the same content dictionary files regardless of their locations, or the same name dictionaries regardless of their content, files names and files locations?

@xiaoyifang
Copy link
Owner Author

What "two versions" means here: the same content and name dictionary files on two different locations, only the same name dictionary files on two different locations, only the same content dictionary files regardless of their locations, or the same name dictionaries regardless of their content, files names and files locations?

the dictionaryid only cares about the filenames ,so the answer should be " or the same name dictionaries regardless of their content"

@GD-fix
Copy link

GD-fix commented Jun 1, 2024

If "the dictionaryid only cares about the filenames" than the answer about "two versions of the same dictionary" must be "only the same name dictionary files on two different locations". Am I right?

@GD-fix
Copy link

GD-fix commented Jun 8, 2024

Is it possible to append to Preferences the option of "moving dictionary files into other folders and have no need to reindex", of course with ATTENTION! about mentioned drawback and full reindex of all dictionaries (and this one option with appropriate ATTENTION! too)?

@xiaoyifang
Copy link
Owner Author

"moving dictionary files into other folders and have no need to reindex", of course with ATTENTION!

I do not think we have time for this. The above function will only be used one time in life.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vNext Improvments and optimizations that need incompatible changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants