FIX: #767 . #788
Merged
FIX: #767 . #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Noted 👍 |
|
Applied the changes 👍 |
xiaolin
reviewed
Feb 23, 2024
src/components/ImageGallery.jsx
Outdated
| const { infinite } = this.props; | ||
| return infinite || this.canSlidePrevious(); | ||
| const { infinite, isRTL } = this.props; | ||
| //so basically is the list is right to left (isRTL), the logic is inversed |
There was a problem hiding this comment.
grammar fix here:
// When isRTL is true, the logic is reversed
There was a problem hiding this comment.
Personally, I would rather have the comment removed because the code you've provided is self-explanatory. But since you left a comment, it will alert a contributor to read it, so it should be clear and concise.
There was a problem hiding this comment.
alright. A side note, it's my first time contributing to kindly excuse any inconvenience caused.
There was a problem hiding this comment.
No inconvenience at all, this is part of the code review process. Thank you for contributing!
xiaolin
reviewed
Feb 27, 2024
xiaolin
reviewed
Feb 27, 2024
xiaolin
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed issue #767. Fixed to bug of left/right navigators only allowing to scroll to first and last image in RTL mode. Now both nav buttons allow slide in the correct direction.