Fix auto play direction in 2 slides #786
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr has fixed(not sure if it's a fix) the swipe direction when there're 2 slides with infinite enabled.
Before this PR, if there're 2 slides only, with
infinite
&autoPlay
enabled, when playing from last slide to the first slide, the direction would be from RIGHT to LEFT:This seems to be correct, but remember when we made slide imperatively from navigation, it works as 'infinite' indeed: the new slide always comes from the right side:
I think the swipe direction(or behaviour) should be same exactly whatever it's from auto play or user gesture? And this PR changes the behaviour in previous case to make it always works like 'infinite':
This PR doesnot make great changes, in opposite, I'm just putting the
slideToIndexWithStyleReset
into theslideToIndex
handler, as all the slide changes goes through here.