Skip to content

Unpin Logback version #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Unpin Logback version #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be5f1b9
Unpin logback version via logback-groovy-config library.
lbwexler Mar 12, 2023
dbbdcc5
Unpin logback version via logback-groovy-config library.
lbwexler Mar 12, 2023
ca10398
Merge branch 'develop' into logbackGroovy
lbwexler Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,14 @@

* grails `5.2.1 -> 5.3.2`

### ⚙️ Breaking Changes
* v16 restores the use of the standard grails version of logback (v1.2.11). Hoist had been
pinned on an earlier version of logback due to dropped support of groovy based configuration.
This support is now restored via plugin. This change will require renaming the
`conf/logback.groovy` file in your application to `conf/logback-config.groovy`. It also may
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this is no longer the case - can stick with logback.groovy as per updated dogbert docs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, not that simple (see below)

require minor adjustments to the syntax of imports in this file. See the `logback-config.groovy`
in toolbox for an example.

## 15.0.0 - 2022-12-5

### 🎁 New Features
Expand Down
1 change: 1 addition & 0 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ dependencies {
api 'org.jasypt:jasypt:1.9.3'
api "commons-io:commons-io:2.8.0"
api "org.owasp.encoder:encoder:1.2.3"
implementation 'io.github.virtualdogbert:logback-groovy-config:1.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are now different versions of this library depending on the particular minor version of logback we're looking to take.

}


Expand Down
1 change: 0 additions & 1 deletion gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ grailsGradlePluginVersion=5.3.0
grailsHibernatePluginVersion=7.3.0
groovyVersion=3.0.9
gormVersion=7.3.2
logback.version=1.2.7

org.gradle.daemon=true
org.gradle.parallel=true
Expand Down
22 changes: 22 additions & 0 deletions src/main/resources/logbackCompiler.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
//-----------------------------------------------------
// This file required by logback-groovy-config plugin to
// allow needed imports in conf/logback-config.

// This plugin is required for logback versions post v.1.2.7 to
// allow configuration via groovy scripts.
//
// See https://virtualdogbert.github.io/logback-groovy-config/
//-------------------------------------------------------------
staticStarImportsAcceptList = [
// From default config
'grails.util.Environment',
'io.micronaut.context.env.Environment',

// Hoist addition
'io.xh.hoist.configuration.LogbackConfig'
]

starImportsAcceptList = [
'io.xh.toolbox.log',
'io.xh.hoist.configuration'
]