Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for onPressMaskBehaviour #363

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add option for onPressMaskBehaviour #363

wants to merge 2 commits into from
+47 −19

Conversation

drop-george
Copy link

@drop-george drop-george commented Sep 9, 2019 •
edited
Loading

This PR makes it possible to change what happens when a user taps the mask.

Before:

  • Tapping mask closes out of the view, and the date selected does not persist

After

  • If onPressMaskBehaviour not set or set to 'cancel'
    • Tapping mask closes out of the view, and the date selected does not persist
  • If onPressMaskBehaviour='confirm'
    • Tapping mask closes out of the view, and the date selected persists

Addresses #327

@coveralls
Copy link

coveralls commented Sep 9, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.05%) to 97.414% when pulling a8c9982 on drop-george:master into 2a209bd on xgfe:master.

@drop-george drop-george mentioned this pull request Sep 10, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drop-evan drop-evan drop-evan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drop-george @coveralls @drop-evan