Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix requires in setup.cfg #171

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Fix requires in setup.cfg #171

merged 1 commit into from
Dec 7, 2021

Conversation

zmoon
Copy link
Contributor

@zmoon zmoon commented Nov 29, 2021

  • removed setuptools from install_requires
  • setup_requires info is specified in pyproject.toml, so removed it
  • added initial groups for cftime and numpy_groupies

@rabernat
Copy link
Collaborator

Thanks a lot for this PR @zmoon! LGTM!

Comment on lines +47 to +50
io =
cftime
agg =
numpy_groupies
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to document these options in the documentation somewhere.

Copy link
Contributor Author

@zmoon zmoon Dec 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, and maybe iso would be a more intuitive name for the agg one since it is only used for the isotropic functions. Also currently numpy_groupies is required for isotropize, so maybe it should be a required dep, or instead a fallback to xarray groupby-bins should be implemented. Or wait, since it seems like xarray may support numpy-groupies for groupby in the near future.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, we will only depend on numpy_groupies until it is incorporated in xarray upstream.

@roxyboy
Copy link
Member

roxyboy commented Dec 7, 2021

So, I guess I'll merge this along with #168 ?

@zmoon
Copy link
Contributor Author

zmoon commented Dec 7, 2021

I still have a bit more I want to do in #168. And there is still the question of the MITgcm data file. But I guess that could be separate.

@roxyboy
Copy link
Member

roxyboy commented Dec 7, 2021

I still have a bit more I want to do in #168. And there is still the question of the MITgcm data file. But I guess that could be separate.

Ok, in that case, I'll merge just #171

@roxyboy roxyboy merged commit 672ddd1 into xgcm:master Dec 7, 2021
@zmoon zmoon deleted the extras branch December 8, 2021 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants