Update: README.md

xfl03 · Jan 27, 2023 · 3e6d0df · 3e6d0df
1 parent e06d71a
commit 3e6d0df
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 35 deletions.
diff --git a/1Locator/src/main/java/me/xfl03/morecrashinfo/fml/ModLocator.java b/1Locator/src/main/java/me/xfl03/morecrashinfo/fml/ModLocator.java
@@ -169,7 +169,7 @@ public Stream<Path> scanCandidates() {
         Path modFolder = FMLPaths.MODSDIR.get();
         logger.debug("Mod folder {}", modFolder);
         visitModDir(modFolder);
-        logger.info("Core path {}", modPath);
+        logger.debug("Core path {}", modPath);
         if (modPath == null) {
             return Stream.empty();
         }
@@ -178,6 +178,7 @@ public Stream<Path> scanCandidates() {
         Path mapped = gameFolder.resolve(
                 String.format("tmp/MoreCrashInfo-Core-%s.jar", VersionUtil.getMinecraftVersion()));
         remapper.processJar(modPath, mapped);
+        logger.info("MoreCrashInfo ModLocator: {}", mapped);
         return Stream.of(mapped);
     }
 

diff --git a/2Loader/src/main/java/me/xfl03/morecrashinfo/modlauncher/ModLocator.java b/2Loader/src/main/java/me/xfl03/morecrashinfo/modlauncher/ModLocator.java
diff --git a/2Loader/src/main/java/me/xfl03/morecrashinfo/modlauncher/TransformerService.java b/2Loader/src/main/java/me/xfl03/morecrashinfo/modlauncher/TransformerService.java
@@ -33,7 +33,7 @@ public void onLoad(IEnvironment env, Set<String> otherServices) throws Incompati
         logger.debug("We are now at MoreCrashInfo TransformationService");
     }
 
-    public static Path corePath;
+//    public static Path corePath;
 
     private Path gameDir;
 
@@ -57,6 +57,7 @@ public void initialize(IEnvironment environment) {
                     String.format("tmp/MoreCrashInfo-Locator-%s.jar", VersionUtil.getMinecraftVersion()));
             JarRemapper remapper = new JarRemapper();
             remapper.processJar(modPath, mapped);
+            logger.info("MoreCrashInfo TransformationService: {}", mapped);
             if (VersionUtil.getMinecraftMajorVersion() < 17) {
                 //Before 1.17, we can add jar to AppClassLoader
                 try {
@@ -119,11 +120,11 @@ private void visitModFile(Path path) {
                 modPath = gameDir.resolve("tmp/MoreCrashInfo-Locator.jar");
                 unzip(zip, ze, modPath);
             }
-            ze = zip.getEntry("MoreCrashInfo-Core.jar");
-            if (ze != null) {
-                corePath = gameDir.resolve("tmp/MoreCrashInfo-Core.jar");
-                unzip(zip, ze, corePath);
-            }
+//            ze = zip.getEntry("MoreCrashInfo-Core.jar");
+//            if (ze != null) {
+//                corePath = gameDir.resolve("tmp/MoreCrashInfo-Core.jar");
+//                unzip(zip, ze, corePath);
+//            }
         } catch (Exception e) {
             logger.warn("Error while loading {}", path);
             logger.warn(e);

diff --git a/.../main/resources/META-INF/services/unused.net.minecraftforge.forgespi.locating.IModLocator b/.../main/resources/META-INF/services/unused.net.minecraftforge.forgespi.locating.IModLocator
diff --git a/README.md b/README.md
@@ -54,7 +54,7 @@ Error Info:
 ```
 
 ## Compatibility
-- Minecraft 1.13.2~1.16.5 & 1.18~1.19.3 with Forge
+- Minecraft 1.13.2~1.19.3 with Forge
 - Java 8~19
 
 ### Tested Environment
@@ -63,6 +63,7 @@ Error Info:
 |:---------:|:--------:|:----:|
 |  1.19.3   |  44.1.2  |  17  |
 |  1.18.2   |  40.2.0  |  17  |
+|  1.17.1   |  37.1.1  |  17  |
 |  1.16.5   | 36.2.39  |  8   |
 |  1.15.2   | 31.2.57  |  8   |
 |  1.14.4   | 28.2.26  |  8   |
@@ -77,6 +78,7 @@ Please use Java 17+ in development or building environment.
 **Build(Gradle `Task`) -> Loader(ModLauncher `ITransformerService`) -> Locator(ForgeSPI `IModLocator`) -> Base(Forge `Mod`)**  
 
 In every `->`(3 times), our mod use ASM to operate bytecode in class file.
+Loader will try to add Locator into classpath, which will make `IModLocator` could be found by ServiceLoader. Our method can suite Java 8-19 and Module Layer with ModLauncher.
 
 ### Build
 ```shell

diff --git a/src/main/java/me/xfl03/morecrashinfo/MoreCrashInfo.java b/src/main/java/me/xfl03/morecrashinfo/MoreCrashInfo.java
@@ -8,4 +8,7 @@
 public class MoreCrashInfo
 {
     public static Logger logger = LogManager.getLogger("MoreCrashInfo");
+    static {
+        logger.info("MoreCrashInfo Mod Loaded");
+    }
 }