Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HID] Enable Keyboard Passthru #127

Open
wants to merge 1 commit into
base: canary_experimental
Choose a base branch
from

Conversation

Gliniak
Copy link
Collaborator

@Gliniak Gliniak commented Feb 9, 2023

No description provided.

namespace xe {
namespace hid {
namespace winkey {

bool __inline IsPassThruForUserEnabled(uint32_t user_index) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't this just be user_index == cvars::keyboard_passthru_user_index
is -1 possible? it doesnt seem like it should be

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it shouldn't. -1 is used but as 0xFF to define any user

@nickcool2901

This comment was marked as spam.

@Rackover
Copy link

Rackover commented Feb 2, 2024

Would love to see merged in, is there any problem with the PR that is currently delaying it ?

@Gliniak
Copy link
Collaborator Author

Gliniak commented Feb 2, 2024

Would love to see merged in, is there any problem with the PR that is currently delaying it ?

Yes, It's not fully functional and doesn't work in some cases

@Rackover
Copy link

Rackover commented Feb 2, 2024

I guess nothing ever is, but it's a start! If it's not breaking any other functionality in the emulator, maybe this could get merged in and improved later?
Of course if it's breaking existing functionality it should not, but maybe it's worth having if it's not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants