Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernized Packages, multiple fixes #488

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

mrflip
Copy link

@mrflip mrflip commented Sep 22, 2022

  • Updated packages to modern expo/react
  • Typescript => 4.x
  • the alpha scroll-to-a-letter thing works even in languages with many characters, with preferred countries, and with Åland
  • search works with modern fuse, and will index against alternative names for the country
  • buttons invalidate correctly when country code is changed (name and calling code were not updated)
  • flag button still shows something even if all the button content options are off
  • if search has no hits, text turns red and full list displays
  • the side scroller no longer filters letters, it just jumps to list positions. the withAlphaFilter option has been removed, but will still toggle on/off the side scroller index if it is not explicitly set on or off.
  • some async error handling" .

@mrflip mrflip force-pushed the ModernizedPkgsTypescript branch 4 times, most recently from f558409 to 601ac5a Compare September 22, 2022 06:40
chore: integrated xcarpentier#475 from kanimetov

chore: updated country code list

fix: was recycling old names

fix: added independent status
* the alpha scroll-to-a-letter thing works even in languages with many characters, with preferred countries, and with Åland
* search works with modern fuse, and will index against alternative names for the country
* buttons invalidate correctly when country code is changed (name and calling code were not updated)
* flag button still shows something even if all the button content options are off
* if search has no hits, text turns red and full list displays
* the side scroller no longer filters letters, it just jumps to list positions. the withAlphaFilter option has been removed, but will still toggle on/off the side scroller index if it is not explicitly set on or off.
* some async error handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant